Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STONEBLD-2525 Move remote task generator #1068

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

stuartwdouglas
Copy link
Contributor

This moves the remote task generator to the build-definitions repo. It means that changes to the generator can no go into the same commit as the corresponding remote task update.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@stuartwdouglas stuartwdouglas force-pushed the move-generator branch 10 times, most recently from 9060a76 to b82e460 Compare June 12, 2024 08:08
@stuartwdouglas stuartwdouglas changed the title Move remote task generator STONEBLD-2525 Move remote task generator Jun 12, 2024
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will feel much better 🌮

go.mod Outdated
@@ -0,0 +1,86 @@
module github.com/konflux-ci/build-definitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the go.mod and go.sum to the remote-task-generator subdirectory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yeah, that would help with EC-690, move of tash for #1039 in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might rename it to task-generator then, once this is in we can look at moving tash

@stuartwdouglas stuartwdouglas force-pushed the move-generator branch 6 times, most recently from d9704bb to 13aa2fd Compare June 13, 2024 13:52
This moves the remote task generator to the build-definitions repo. It means that changes to the generator can no go into the same commit as the corresponding remote task update.
@stuartwdouglas
Copy link
Contributor Author

Should be ready now

Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stuartwdouglas stuartwdouglas added this pull request to the merge queue Jun 20, 2024
Merged via the queue into konflux-ci:main with commit 0b9a515 Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants