-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STONEBLD-2525 Move remote task generator #1068
STONEBLD-2525 Move remote task generator #1068
Conversation
ab92782
to
b2c3c82
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
9060a76
to
b82e460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this will feel much better 🌮
go.mod
Outdated
@@ -0,0 +1,86 @@ | |||
module github.com/konflux-ci/build-definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the go.mod and go.sum to the remote-task-generator subdirectory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yeah, that would help with EC-690, move of tash for #1039 in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might rename it to task-generator then, once this is in we can look at moving tash
d9704bb
to
13aa2fd
Compare
This moves the remote task generator to the build-definitions repo. It means that changes to the generator can no go into the same commit as the corresponding remote task update.
13aa2fd
to
a78146a
Compare
Should be ready now |
167318c
to
6ffe8a4
Compare
6ffe8a4
to
ba12cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This moves the remote task generator to the build-definitions repo. It means that changes to the generator can no go into the same commit as the corresponding remote task update.